lkml.org 
[lkml]   [2017]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.10 07/63] vxlan: correctly validate VXLAN ID against VXLAN_N_VID
    Date
    4.10-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Matthias Schiffer <mschiffer@universe-factory.net>


    [ Upstream commit 4e37d6911f36545b286d15073f6f2222f840e81c ]

    The incorrect check caused an off-by-one error: the maximum VID 0xffffff
    was unusable.

    Fixes: d342894c5d2f ("vxlan: virtual extensible lan")
    Signed-off-by: Matthias Schiffer <mschiffer@universe-factory.net>
    Acked-by: Jiri Benc <jbenc@redhat.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/vxlan.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/net/vxlan.c
    +++ b/drivers/net/vxlan.c
    @@ -2626,7 +2626,7 @@ static int vxlan_validate(struct nlattr

    if (data[IFLA_VXLAN_ID]) {
    __u32 id = nla_get_u32(data[IFLA_VXLAN_ID]);
    - if (id >= VXLAN_VID_MASK)
    + if (id >= VXLAN_N_VID)
    return -ERANGE;
    }


    \
     
     \ /
      Last update: 2017-03-20 19:08    [W:4.244 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site