[lkml]   [2017]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH tip] x86/mm: Correct fixmap header usage on adaptable MODULES_END
On Mon, Mar 20, 2017 at 07:31:17AM -0700, Thomas Garnier wrote:
>On Sun, Mar 19, 2017 at 6:14 PM, Wei Yang <> wrote:
>> On Sun, Mar 19, 2017 at 09:25:00AM -0700, Thomas Garnier wrote:
>>>On Sun, Mar 19, 2017 at 9:03 AM, Wei Yang <> wrote:
>>>> On Fri, Mar 17, 2017 at 10:50:34AM -0700, Thomas Garnier wrote:
>>>>>This patch remove fixmap header usage on non-x86 code that was
>>>>>introduced by the adaptable MODULE_END change.
>>>> Hi, Thomas
>>>> In this patch, it looks you are trying to do two things for my understanding:
>>>> 1. To include <asm/fixmap.h> in asm/pagetable_64.h and remove the include in
>>>> some of the x86 files
>>>> 2. Remove <asm/fixmap.h> in mm/vmalloc.c
>>>> I think your change log covers the second task in the patch, but not not talk
>>>> about the first task you did in the patch. If you could mention it in commit
>>>> log, it would be good for maintain.
>>>I agree, I am not the best at writing commits (by far). What's the
>>>best way for me to correct that? (the bot seem to have taken it).
>> Simply mention it in your commit log is enough to me.
>I meant, do I send another patch or reply on in this thread and bot
>will pick it up?

I think it is necessary to send V2.

Wei Yang
Help you, Help me
[unhandled content-type:application/pgp-signature]
 \ /
  Last update: 2017-03-20 17:54    [W:0.043 / U:3.076 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site