Messages in this thread | | | Date | Mon, 20 Mar 2017 09:04:25 -0500 | From | Josh Poimboeuf <> | Subject | Re: [PATCH 6/6 v3] ftrace/x86: Use Makefile logic instead of #ifdef of compling ftrace_*.o |
| |
On Sat, Mar 18, 2017 at 05:09:29PM -0400, Steven Rostedt wrote: > From: "Steven Rostedt (VMware)" <rostedt@goodmis.org> > > Currently ftrace_32.S and ftrace_64.S are compiled even when > CONFIG_FUNCTION_TRACER is not set. This means there's an unnecessary #ifdef > to protect the code. Instead of using preprocessor directives, only compile > those files when FUNCTION_TRACER is defined. > > Link: http://lkml.kernel.org/r/20170316210043.peycxdxktwwn6cid@treble > Suggested-by: Josh Poimboeuf <jpoimboe@redhat.com> > Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
The subject has a typo ("compling") and would parse better if the second "of" where changed to a "for": "for compiling". Otherwise:
Reviewed-by: Josh Poimboeuf <jpoimboe@redhat.com>
-- Josh
| |