Messages in this thread | | | Subject | Re: [PATCH 03/15] extcon: cht-wc: Add Intel Cherry Trail Whiskey Cove PMIC extcon driver | From | Andy Shevchenko <> | Date | Mon, 20 Mar 2017 15:00:41 +0200 |
| |
On Mon, 2017-03-20 at 10:33 +0900, Chanwoo Choi wrote: > On 2017년 03월 17일 18:55, Hans de Goede wrote:
> > +static const struct platform_device_id cht_wc_extcon_table[] = { > > + { .name = "cht_wcove_pwrsrc" }, > > You use the 'cht_wc' word instead of 'cht_wcove_pwrsrc'. > So, To maintain the consistency, you better to use the 'cht-wc' as the > name. > - I prefer to use '-' instead of '_' in the name. > .name ="cht-wc"
I would keep as Hans did for the sake of consistency among all Whiskey Cove device drivers (and predecessors like Crystal Cove).
I understand your point from extcon subsystem view, but PMICs like Whiskey Cove are multi-functional devices, and thus naming across them (same prefix in use to be precise) is better idea.
> > > + {}, > > +}; > > +MODULE_DEVICE_TABLE(platform, cht_wc_extcon_table);
-- Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy
| |