Messages in this thread | | | Date | Mon, 20 Mar 2017 10:33:55 +0100 | From | Maxime Ripard <> | Subject | Re: [PATCH] clk: sunxi-ng: fix recalc_rate formula of NKMP clocks |
| |
On Sat, Mar 18, 2017 at 04:19:43AM +0800, Icenowy Zheng wrote: > In commit e66f81bbd746 ("clk: sunxi-ng: Implement factors offsets"), the > final formula of NKMP clocks' recalc_rate is refactored; however, the > refactored formula broke the calculation due to some C language operand > priority problem -- the priority of operand >> is lower than * and /, > makes the formula being parsed as "(parent_rate * n * k) >> (p / m)", but > it should be "(parent_rate * n * k >> p) / m". > > Add the pair of parentheses to fix up this issue. This pair of > parentheses used to exist in the old formula. > > Fixes: commit e66f81bbd746 ("clk: sunxi-ng: Implement factors offsets")
You shouldn't have commit here.
> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
Fixed it, and applied, thanks! Maxime
-- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com [unhandled content-type:application/pgp-signature] | |