Messages in this thread | | | Date | Thu, 2 Mar 2017 14:36:46 +0900 | From | Sergey Senozhatsky <> | Subject | Re: [PATCH] x86/hpet: Prevent might sleep splat on resume |
| |
On (03/01/17 21:10), Thomas Gleixner wrote: > Sergey reported a might sleep warning triggered from the hpet resume > path. It's caused by the call to disable_irq() from interrupt disabled > context. > > The problem with the low level resume code is that it is not accounted as a > special system_state like we do during the boot process. Calling the same > code during system boot would not trigger the warning. That's inconsistent > at best. > > In this particular case it's trivial to replace the disable_irq() with > disable_hardirq() because this particular code path is solely used from > system resume and the involved hpet interrupts can never be force threaded. > > Reported-by: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> > Signed-off-by: Thomas Gleixner <tglx@linutronix.de> > Cc: stable@vger.kernel.org
Tested-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
thanks!
-ss
| |