Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Fri, 17 Mar 2017 08:56:07 +0100 | Subject | Re: [PATCH v15 6/9] x86/arch_prctl: Add ARCH_[GET|SET]_CPUID |
| |
Hi Linus,
On Thu, Mar 16, 2017 at 7:23 PM, Linus Torvalds <torvalds@linux-foundation.org> wrote: > On Thu, Mar 16, 2017 at 7:30 AM, Kyle Huey <me@kylehuey.com> wrote: >> On Thu, Mar 16, 2017 at 4:09 AM, Michael Ellerman <mpe@ellerman.id.au> wrote: >>> >>> Presumably he's done: >>> >>> $ git config diff.context 8 >> >> Indeed. In my case it dates back to my days hacking on Firefox, which >> wants 8 lines of context for patches. I'll remove it. > > You can make those kinds of options per-repository rather than > user-global, so you can keep the 8-line thing for firefox without > having it for the kernel. > > Not that it *hurts* for the kernel, but it just looked odd to me > because the patch looked so much bigger. More context lines can > obviously help with ambiguous cases, but we very seldom have that kind > of ambiguity.
Having a larger default for DTS source files could be a good idea, though. I regularly use -U10 to verify DTS patches were applied correctly.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |