lkml.org 
[lkml]   [2017]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] Fix the issue that V8 Button pad Stick button does not work
On Tue, Mar 14, 2017 at 10:34:13AM +0900, Masaki Ota wrote:
> From: Masaki Ota <masaki.ota@jp.alps.com>
> - V8 Button pad Stick Right and Middle button don't work.
> - Alps stick devices have physical buttons absolutely, so delete "ALPS_BUTTONPAD" check Flag from Stick button process.
>
> Signed-off-by: Masaki Ota <masaki.ota@jp.alps.com>
>
> Acked-by: Pali Rohar <pali.rohar@gmail.com>

Reworded commit message, marked for stable and applied, thank you.

> ---
> drivers/input/mouse/alps.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c
> index 253f742..262d105 100644
> --- a/drivers/input/mouse/alps.c
> +++ b/drivers/input/mouse/alps.c
> @@ -1287,10 +1287,8 @@ static int alps_decode_ss4_v2(struct alps_fields *f,
> /* handle buttons */
> if (pkt_id == SS4_PACKET_ID_STICK) {
> f->ts_left = !!(SS4_BTN_V2(p) & 0x01);
> - if (!(priv->flags & ALPS_BUTTONPAD)) {
> - f->ts_right = !!(SS4_BTN_V2(p) & 0x02);
> - f->ts_middle = !!(SS4_BTN_V2(p) & 0x04);
> - }
> + f->ts_right = !!(SS4_BTN_V2(p) & 0x02);
> + f->ts_middle = !!(SS4_BTN_V2(p) & 0x04);
> } else {
> f->left = !!(SS4_BTN_V2(p) & 0x01);
> if (!(priv->flags & ALPS_BUTTONPAD)) {
> --
> 2.9.3
>

--
Dmitry

\
 
 \ /
  Last update: 2017-03-17 22:27    [W:1.109 / U:0.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site