Messages in this thread | | | Subject | Re: [PATCH v2 1/4] platform/x86: intel_pmc_ipc: fix gcr offset | From | sathyanarayanan kuppuswamy <> | Date | Fri, 17 Mar 2017 10:06:27 -0700 |
| |
On 03/17/2017 04:13 AM, Rajneesh Bhardwaj wrote: > On Thu, Mar 16, 2017 at 05:41:33PM -0700, Kuppuswamy Sathyanarayanan wrote: >> According to the PMC spec, gcr offset from ipc mem >> region is 0x1000(4K). But currently this driver uses >> 0x1008 as gcr offset. This patch fixes this issue. >> > This one is fine and was one of the WIP patches. This now enables further > cleanup and we should re-align GCR_TELEM_DEEP_S0IX_OFFSET from gcr_base. Since S0IX_OFFSET currently does not use GCR_OFFSET as base, I think that change is irrelevant to this fix. I can submit another patch for S0IX_OFFSET cleanup. > > CC: Shanth Murthy <shanth.murthy@intel.com> > >> Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com> >> --- >> drivers/platform/x86/intel_pmc_ipc.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/platform/x86/intel_pmc_ipc.c b/drivers/platform/x86/intel_pmc_ipc.c >> index 0651d47..0a33592 100644 >> --- a/drivers/platform/x86/intel_pmc_ipc.c >> +++ b/drivers/platform/x86/intel_pmc_ipc.c >> @@ -82,7 +82,7 @@ >> /* exported resources from IFWI */ >> #define PLAT_RESOURCE_IPC_INDEX 0 >> #define PLAT_RESOURCE_IPC_SIZE 0x1000 >> -#define PLAT_RESOURCE_GCR_OFFSET 0x1008 >> +#define PLAT_RESOURCE_GCR_OFFSET 0x1000 >> #define PLAT_RESOURCE_GCR_SIZE 0x1000 >> #define PLAT_RESOURCE_BIOS_DATA_INDEX 1 >> #define PLAT_RESOURCE_BIOS_IFACE_INDEX 2 >> -- >> 2.7.4 >>
-- Sathyanarayanan Kuppuswamy Android kernel developer
| |