lkml.org 
[lkml]   [2017]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [f2fs-dev] [PATCH 2/2] f2fs: don't allow atomic writes for not regular files
On 03/17, Chao Yu wrote:
> On 2017/3/17 10:09, Jaegeuk Kim wrote:
> > The atomic writes only supports regular files for database.
> >
> > Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> > ---
> > fs/f2fs/file.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> > index da6d33d1bb34..d486e02b43c2 100644
> > --- a/fs/f2fs/file.c
> > +++ b/fs/f2fs/file.c
> > @@ -1522,6 +1522,9 @@ static int f2fs_ioc_start_atomic_write(struct file *filp)
> > if (f2fs_is_atomic_file(inode))
> > goto out;
> >
> > + if (!S_ISREG(inode->i_mode))
> > + return -EINVAL;
>
> goto out;

Oh, I just move it to the beginning of the function.

Thanks,

>
> Thanks,
>
> > +
> > ret = f2fs_convert_inline_inode(inode);
> > if (ret)
> > goto out;
> >

\
 
 \ /
  Last update: 2017-03-17 14:09    [W:0.429 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site