Messages in this thread | | | Date | Wed, 15 Mar 2017 10:16:57 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH v5 3/7] perf/sdt: Directly record SDT events with 'perf record' |
| |
Em Wed, Mar 15, 2017 at 01:03:31PM +0100, Jiri Olsa escreveu: > On Tue, Mar 14, 2017 at 08:36:54PM +0530, Ravi Bangoria wrote: > > +++ b/tools/perf/builtin-record.c > > +static int record__parse_events_option(const struct option *opt, > > + const char *str, > > + int unset) > > +{ > > + if (is_sdt_event((char *) str)) > > + return parse_sdt_events_option(opt, str, unset); > > + else > > + return parse_events_option(opt, str, unset); > > so what happens if there're more than one event in 'str' like: > -e cycles,std_... > > would it be better to plug this directly into parse-events.y > parser.. and handle it like any other event type?
Yeah, I went to bed thinking about this :-)
Ravi,
Please test something like:
perf record -e cycles,sdt_glib:mem__alloc,sched:*switch -a sleep 5s
- Arnaldo
- Arnaldo
| |