Messages in this thread Patch in this message | | | Subject | Re: [PATCH 23/35] drivers/mfd: Convert remaining uses of pr_warning to pr_warn | From | Joe Perches <> | Date | Tue, 14 Mar 2017 10:17:48 -0700 |
| |
On Tue, 2017-03-14 at 14:04 +0000, Lee Jones wrote: > On Thu, 16 Feb 2017, Joe Perches wrote: > > To enable eventual removal of pr_warning [] > > diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c [] > > @@ -502,9 +502,7 @@ static int load_twl4030_script(const struct twl4030_power_data *pdata, > > } > > if (tscript->flags & TWL4030_SLEEP_SCRIPT) { > > if (!order) > > - pr_warning("TWL4030: Bad order of scripts (sleep "\ > > - "script before wakeup) Leads to boot"\ > > - "failure on some boards\n"); > > + pr_warn("TWL4030: Bad order of scripts (sleep script before wakeup) Leads to boot failure on some boards\n"); > > Is 80 chars considered the lessor sin?
Splitting logging messages into multiple lines is non preferred.
Documentation/process/coding-style.rst:
Breaking long lines and strings:
never break user-visible strings such as printk messages, because that breaks the ability to grep for them.
| |