lkml.org 
[lkml]   [2017]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 188/370] HID: hid-cypress: validate length of report
    3.16.42-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    commit 1ebb71143758f45dc0fa76e2f48429e13b16d110 upstream.

    Make sure we have enough of a report structure to validate before
    looking at it.

    Reported-by: Benoit Camredon <benoit.camredon@airbus.com>
    Tested-by: Benoit Camredon <benoit.camredon@airbus.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Jiri Kosina <jkosina@suse.cz>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/hid/hid-cypress.c | 3 +++
    1 file changed, 3 insertions(+)

    --- a/drivers/hid/hid-cypress.c
    +++ b/drivers/hid/hid-cypress.c
    @@ -39,6 +39,9 @@ static __u8 *cp_report_fixup(struct hid_
    if (!(quirks & CP_RDESC_SWAPPED_MIN_MAX))
    return rdesc;

    + if (*rsize < 4)
    + return rdesc;
    +
    for (i = 0; i < *rsize - 4; i++)
    if (rdesc[i] == 0x29 && rdesc[i + 2] == 0x19) {
    __u8 tmp;
    \
     
     \ /
      Last update: 2017-03-10 13:36    [W:4.092 / U:0.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site