lkml.org 
[lkml]   [2017]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 098/153] w1: dont leak refcount on slave attach failure in w1_attach_slave_device()
    Date
    4.9-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Maciej S. Szmigiero <mail@maciej.szmigiero.name>

    commit d2ce4ea1a0b0162e5d2d7e7942ab6f5cc2063d5a upstream.

    Near the beginning of w1_attach_slave_device() we increment a w1 master
    reference count.
    Later, when we are going to exit this function without actually attaching
    a slave device (due to failure of __w1_attach_slave_device()) we need to
    decrement this reference count back.

    Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
    Fixes: 9fcbbac5ded489 ("w1: process w1 netlink commands in w1_process thread")
    Cc: Evgeniy Polyakov <zbr@ioremap.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/w1/w1.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/w1/w1.c
    +++ b/drivers/w1/w1.c
    @@ -763,6 +763,7 @@ int w1_attach_slave_device(struct w1_mas
    dev_err(&dev->dev, "%s: Attaching %s failed.\n", __func__,
    sl->name);
    w1_family_put(sl->family);
    + atomic_dec(&sl->master->refcnt);
    kfree(sl);
    return err;
    }

    \
     
     \ /
      Last update: 2017-03-10 12:06    [W:4.141 / U:0.992 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site