lkml.org 
[lkml]   [2017]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 070/153] ext4: trim allocation requests to group size
    Date
    4.9-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Jan Kara <jack@suse.cz>

    commit cd648b8a8fd5071d232242d5ee7ee3c0815776af upstream.

    If filesystem groups are artifically small (using parameter -g to
    mkfs.ext4), ext4_mb_normalize_request() can result in a request that is
    larger than a block group. Trim the request size to not confuse
    allocation code.

    Reported-by: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
    Signed-off-by: Jan Kara <jack@suse.cz>
    Signed-off-by: Theodore Ts'o <tytso@mit.edu>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/ext4/mballoc.c | 7 +++++++
    1 file changed, 7 insertions(+)

    --- a/fs/ext4/mballoc.c
    +++ b/fs/ext4/mballoc.c
    @@ -3123,6 +3123,13 @@ ext4_mb_normalize_request(struct ext4_al
    if (ar->pright && start + size - 1 >= ar->lright)
    size -= start + size - ar->lright;

    + /*
    + * Trim allocation request for filesystems with artificially small
    + * groups.
    + */
    + if (size > EXT4_BLOCKS_PER_GROUP(ac->ac_sb))
    + size = EXT4_BLOCKS_PER_GROUP(ac->ac_sb);
    +
    end = start + size;

    /* check we don't cross already preallocated blocks */

    \
     
     \ /
      Last update: 2017-03-10 12:04    [W:2.329 / U:0.364 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site