lkml.org 
[lkml]   [2017]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 1/2] extcon: int3496: Use gpiod_get instead of gpiod_get_index
On Fri, Mar 10, 2017 at 10:52 PM, Hans de Goede <hdegoede@redhat.com> wrote:
> Now that we've an acpi mapping table we should be using gpiod_get
> instead of gpiod_get_index.

Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

Chanwoo, this patch is essentially needed since I missed the change in
my latest patch in extcon.


> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> drivers/extcon/extcon-intel-int3496.c | 12 +++---------
> 1 file changed, 3 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/extcon/extcon-intel-int3496.c b/drivers/extcon/extcon-intel-int3496.c
> index 43ba84ea..b8ac947 100644
> --- a/drivers/extcon/extcon-intel-int3496.c
> +++ b/drivers/extcon/extcon-intel-int3496.c
> @@ -107,9 +107,7 @@ static int int3496_probe(struct platform_device *pdev)
> data->dev = dev;
> INIT_DELAYED_WORK(&data->work, int3496_do_usb_id);
>
> - data->gpio_usb_id = devm_gpiod_get_index(dev, "id",
> - INT3496_GPIO_USB_ID,
> - GPIOD_IN);
> + data->gpio_usb_id = devm_gpiod_get(dev, "id", GPIOD_IN);
> if (IS_ERR(data->gpio_usb_id)) {
> ret = PTR_ERR(data->gpio_usb_id);
> dev_err(dev, "can't request USB ID GPIO: %d\n", ret);
> @@ -122,15 +120,11 @@ static int int3496_probe(struct platform_device *pdev)
> return data->usb_id_irq;
> }
>
> - data->gpio_vbus_en = devm_gpiod_get_index(dev, "vbus",
> - INT3496_GPIO_VBUS_EN,
> - GPIOD_ASIS);
> + data->gpio_vbus_en = devm_gpiod_get(dev, "vbus", GPIOD_ASIS);
> if (IS_ERR(data->gpio_vbus_en))
> dev_info(dev, "can't request VBUS EN GPIO\n");
>
> - data->gpio_usb_mux = devm_gpiod_get_index(dev, "mux",
> - INT3496_GPIO_USB_MUX,
> - GPIOD_ASIS);
> + data->gpio_usb_mux = devm_gpiod_get(dev, "mux", GPIOD_ASIS);
> if (IS_ERR(data->gpio_usb_mux))
> dev_info(dev, "can't request USB MUX GPIO\n");
>
> --
> 2.9.3
>



--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2017-03-10 23:10    [W:0.089 / U:0.436 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site