Messages in this thread | | | Subject | Re: [PATCH fixes v2] pinctrl: Really force states during suspend/resume | From | Florian Fainelli <> | Date | Wed, 1 Mar 2017 10:29:00 -0800 |
| |
On 02/27/2017 03:06 PM, Florian Fainelli wrote: > In case a platform only defaults a "default" set of pins, but not a > "sleep" set of pins, and this particular platform suspends and resumes > in a way that the pin states are not preserved by the hardware, when we > resume, we would call pinctrl_single_resume() -> pinctrl_force_default() > -> pinctrl_select_state() and the first thing we do is check that the > pins state is the same as before, and do nothing. > > In order to fix this, decouple pinctrl_select_state and make it become > pinctrl_commit_state(), taking an additional ignore_state_check boolean > which allows us to bypass the state check during suspend/resume, since > we really want to re-apply the previous pin states in these case. > > Fixes: 6e5e959dde0d ("pinctrl: API changes to support multiple states per device") > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Linus, I have a better version of this coming where the p->state == state check is just moved into pinctrl_select_state() instead. -- Florian
| |