lkml.org 
[lkml]   [2017]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] thermal: add support for the thermal sensor on Allwinner new SoCs
On Wed, Mar 01, 2017 at 06:20:51PM +0800, Icenowy Zheng wrote:
>
> 2017年3月1日 18:14于 Maxime Ripard <maxime.ripard@free-electrons.com>写道:
> >
> > On Tue, Feb 28, 2017 at 03:18:13PM +0800, Icenowy Zheng wrote:
> > >
> > > 2017年2月28日 14:44于 Maxime Ripard <maxime.ripard@free-electrons.com>写道:
> > > >
> > > > On Tue, Feb 28, 2017 at 03:40:53AM +0800, Icenowy Zheng wrote:
> > > > > From: Ondrej Jirman <megous@megous.com>
> > > > >
> > > > > Allwinner SoCs from H3 (including H5, A64, etc) have a new version of
> > > > > thermal sensor, and needs a new driver for it.
> > > > >
> > > > > Add such a driver.
> > > > >
> > > > > Currently only H3 is supported, but other SoCs are easily to be
> > > > > supported by adding new formula and set the sensor number.
> > > > >
> > > > > Signed-off-by: Ondřej Jirman <megous@megous.com>
> > > > > [Icenowy: extend to support further multiple-sensor SoCs, change commit
> > > > >  message]
> > > > > Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
> > > >
> > > > There's no need to create a new driver for that. This can be handled
> > > > by the GPADC driver we already have.
> > >
> > > sun8i-ths is not GPADC at all.
> > >
> > > The latest SoC I know that use GPADC as thermal sensor is A33.
> >
> > It's not called the same way, but it definitely is an evolution of the
> > same controller. There's no need for a new driver, only reworking what
> > is already there.
>
> I don't think so -- here's some evidence:
>
> 1. The old GPADC do not have module clock.

The A33 could use a PLL.

> 2. The old GPADC do not have calibration stored in eFUSE.

The A33 had calibration data stored in the efuses.

> 3. R40 SoC have both RTP (it should be the old GPADC) and
> new-generation THS.

And this is probably just to be compatible with the A20.

Maxime

--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2017-03-01 17:16    [W:0.095 / U:0.388 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site