Messages in this thread | | | Date | Wed, 1 Mar 2017 20:46:59 +0530 | From | "Naveen N. Rao" <> | Subject | Re: [PATCH v2 3.5/5] trace/kprobes: Add back warning about offset in return probes |
| |
On 2017/02/27 11:52AM, Steven Rostedt (VMware) wrote: > Let's not remove the warning about offsets and return probes when the > offset is invalid.
Good point!
Thanks, Steve!
> > Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Acked-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
> --- > diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c > index 3f4f788..f626235 100644 > --- a/kernel/trace/trace_kprobe.c > +++ b/kernel/trace/trace_kprobe.c > @@ -695,6 +695,11 @@ static int create_trace_kprobe(int argc, char **argv) > pr_info("Failed to parse symbol.\n"); > return ret; > } > + if (offset && is_return && > + !arch_function_offset_within_entry(offset)) { > + pr_info("Given offset is not valid for return probe.\n"); > + return -EINVAL; > + } > } > argc -= 2; argv += 2; > >
| |