lkml.org 
[lkml]   [2017]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/4] MIPS: Handle non word sized instructions when examining frame
From
Date
Hi Maciej


On 28/02/17 20:54, Maciej W. Rozycki wrote:
> On Tue, 28 Feb 2017, Matt Redfearn wrote:
>
>> Since the instruction modifying the stack pointer is usually the first
>> in the function, that one is ususally handled correctly. But the
> s/ususally/usually/

oops

>
>> diff --git a/arch/mips/kernel/process.c b/arch/mips/kernel/process.c
>> index 803e255b6fc3..5b1e932ae973 100644
>> --- a/arch/mips/kernel/process.c
>> +++ b/arch/mips/kernel/process.c
>> @@ -347,6 +347,7 @@ static int get_frame_info(struct mips_frame_info *info)
>> union mips_instruction insn, *ip, *ip_end;
>> const unsigned int max_insns = 128;
>> unsigned int i;
>> + unsigned int last_insn_size = 0;
> Please keep declarations in the reverse Christmas tree order, i.e. swap
> the last two.
>
> Maciej

OK, no problem.
Thanks,
Matt

\
 
 \ /
  Last update: 2017-03-01 15:08    [W:0.235 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site