Messages in this thread | | | Subject | Re: [PATCH 1/2] vfs: implement fchmodat2() syscall | From | Eric Blake <> | Date | Tue, 28 Feb 2017 12:59:41 -0600 |
| |
On 02/28/2017 12:41 PM, Greg Kurz wrote:
>>> +++ b/include/linux/syscalls.h >>> @@ -775,6 +775,8 @@ asmlinkage long sys_futimesat(int dfd, const char __user *filename, >>> asmlinkage long sys_faccessat(int dfd, const char __user *filename, int mode); >>> asmlinkage long sys_fchmodat(int dfd, const char __user * filename, >>> umode_t mode); >>> +asmlinkage long sys_fchmodat2(int dfd, const char __user *filename, >>> + umode_t mode, int flag); >>> asmlinkage long sys_fchownat(int dfd, const char __user *filename, uid_t user, >>> gid_t group, int flag); >> >> Is the indentation off here? >> > > This is linux style indent with tabs+spaces. FWIW it is displayed correctly > in vi and emacs (I've simply copied the sys_fchmodat() declaration).
Sorry for the noise; I see that it is correct now, since fchmodat2 is one bye longer than fchmodat or fchownat. Sometimes, I wish I could convince my mailer to display leading tabs as exactly 8 spaces rather than to the next 8-space tab stop, so that prefixed characters that aren't tab-stop aligned don't mess with the actual visual output.
-- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
[unhandled content-type:application/pgp-signature] | |