lkml.org 
[lkml]   [2017]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] perf tools: Support end symbols with no size for filters
> > -		no_size = !!size;
>
> Erk! Isn't the logic is the wrong way around here. Sorry!
> i.e. should be:

Yes it works with that change too.

>
> diff --git a/tools/perf/util/auxtrace.c b/tools/perf/util/auxtrace.c
> index c5a6e0b12452..78bd632f144d 100644
> --- a/tools/perf/util/auxtrace.c
> +++ b/tools/perf/util/auxtrace.c
> @@ -1826,7 +1826,7 @@ static int addr_filter__resolve_kernel_syms(struct addr_filter *filt)
> filt->addr = start;
> if (filt->range && !filt->size && !filt->sym_to) {
> filt->size = size;
> - no_size = !!size;
> + no_size = !size;
> }
> }
>
> @@ -1840,7 +1840,7 @@ static int addr_filter__resolve_kernel_syms(struct addr_filter *filt)
> if (err)
> return err;
> filt->size = start + size - filt->addr;
> - no_size = !!size;
> + no_size = !size;
> }
>

\
 
 \ /
  Last update: 2017-02-10 00:01    [W:0.119 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site