Messages in this thread | | | Date | Thu, 9 Feb 2017 17:09:17 +0900 | From | Minchan Kim <> | Subject | Re: [PATCH v2] mm/zsmalloc: fix comment in zsmalloc |
| |
On Thu, Feb 09, 2017 at 04:05:43PM +0900, Sergey Senozhatsky wrote: > On (02/09/17 14:13), Yisheng Xie wrote: > > The class index and fullness group are not encoded in (first)page->mapping > > any more, after commit 3783689a1aa8 ("zsmalloc: introduce zspage > > structure"). Instead, they are store in struct zspage. Just delete this > > unneeded comment. > > > > Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com> > > Suggested-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com> > > Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com> > > Cc: Minchan Kim <minchan@kernel.org> > > Cc: Nitin Gupta <ngupta@vflare.org> > > Cc: Hanjun Guo <guohanjun@huawei.com> Acked-by: Minchan Kim <minchan@kernel.org>
> > --- > > v2: > > * just delete the comment for it is no need anymore, suggested by Sergey. > > thanks for the patch. > > my "suggestion" was just a side note, nothing more. I'm fine with the > "fix the comment" patch that Andrew has added to mmotm. > we need Minchan's opinion on this, until he speaks out let's have V1 > ("fix the comment") applied.
I agree on Sergey's opinion.
Andrew, Please drop previous patch and replace it with this.
Thanks.
| |