Messages in this thread | | | Subject | Re: [PATCH net-next v3 04/11] bpf: Use bpf_load_program() from the library | From | Mickaël Salaün <> | Date | Wed, 8 Feb 2017 21:08:29 +0100 |
| |
On 08/02/2017 20:46, Arnaldo Carvalho de Melo wrote: > Em Tue, Feb 07, 2017 at 03:17:43PM -0800, Alexei Starovoitov escreveu: >> On 2/7/17 1:44 PM, Mickaël Salaün wrote: >>> - union bpf_attr attr; >>> + union bpf_attr attr = {}; >>> >>> - bzero(&attr, sizeof(attr)); >> >> I think somebody mentioned that there are compilers out there >> that don't do it correctly, hence it was done with explicit bzero. >> Arnaldo, Wang, do you remember the details? > > https://www.spinics.net/lists/netdev/msg411144.html > > But this was when some named initializers are used in a union with > unnamed members like 'union bpf_attr', unsure if this would break with > the above case where no named initializers are being used. > > Having that said, the above is gratuitous, the code that is being > replaced is not related to the patch at hand, and conceptually the end > result should be the same. > > So, please, just leave it as is, i.e. using bzero() and make your patch > a bit smaller, remember, small is good, smaller is even better ;-) > > - Arnaldo >
Right, I'll do it.
Thanks
[unhandled content-type:application/pgp-signature]
| |