lkml.org 
[lkml]   [2017]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 31/53] sched/headers: Move <asm/current.h> include from the middle of <linux/sched.h> to the header portion
    Date
    Linux-0.01 already defined 'current' in the middle of sched.h, so this
    is an ancient historical precedent - but still in a modern kernel it
    looks a bit weird that we have:

    #include <asm/current.h>

    in the middle of the header.

    Move it further up. If this was done for some obscure dependency
    reasons then we'll trigger and document it.

    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Mike Galbraith <efault@gmx.de>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: linux-kernel@vger.kernel.org
    Signed-off-by: Ingo Molnar <mingo@kernel.org>
    ---
    include/linux/sched.h | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/include/linux/sched.h b/include/linux/sched.h
    index 7cdafec9ec33..1ffbf7b1ca06 100644
    --- a/include/linux/sched.h
    +++ b/include/linux/sched.h
    @@ -31,6 +31,8 @@
    #include <linux/magic.h>
    #include <linux/cgroup-defs.h>

    +#include <asm/current.h>
    +
    struct sched_attr;
    struct sched_param;

    @@ -1573,8 +1575,6 @@ extern struct task_struct *find_task_by_vpid(pid_t nr);
    extern struct task_struct *find_task_by_pid_ns(pid_t nr,
    struct pid_namespace *ns);

    -#include <asm/current.h>
    -
    extern int wake_up_state(struct task_struct *tsk, unsigned int state);
    extern int wake_up_process(struct task_struct *tsk);
    extern void wake_up_new_task(struct task_struct *tsk);
    --
    2.7.4
    \
     
     \ /
      Last update: 2017-02-08 19:51    [W:4.513 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site