Messages in this thread Patch in this message | | | Date | Wed, 8 Feb 2017 13:36:37 +0200 | From | Jarkko Sakkinen <> | Subject | Re: [PATCH -next] tpm_tis: fix the error handling of init_tis() |
| |
On Tue, Feb 07, 2017 at 03:51:47PM +0000, Wei Yongjun wrote: > From: Wei Yongjun <weiyongjun1@huawei.com> > > Add the missing platform_driver_unregister() and remove the duplicate > platform_device_unregister(force_pdev) in the error handling case. > > Fixes: 00194826e6be ("tpm_tis: Clean up the force=1 module parameter") > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
/Jarkko
> --- > drivers/char/tpm/tpm_tis.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c > index 7912dad..c7e1384 100644 > --- a/drivers/char/tpm/tpm_tis.c > +++ b/drivers/char/tpm/tpm_tis.c > @@ -432,7 +432,7 @@ static int __init init_tis(void) > acpi_bus_unregister_driver(&tis_acpi_driver); > err_acpi: > #endif > - platform_device_unregister(force_pdev); > + platform_driver_unregister(&tis_drv); > err_platform: > if (force_pdev) > platform_device_unregister(force_pdev); >
| |