Messages in this thread | | | From | Felipe Balbi <> | Subject | Re: [PATCH 1/2] drivers: usb: gadget: udc: add missing break in switch | Date | Wed, 08 Feb 2017 11:23:27 +0200 |
| |
Hi,
"Gustavo A. R. Silva" <garsilva@embeddedor.com> writes: > Add missing break in switch. > > Addresses-Coverity-ID: 201385 > Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> > --- > drivers/usb/gadget/udc/mv_udc_core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/gadget/udc/mv_udc_core.c b/drivers/usb/gadget/udc/mv_udc_core.c > index 27ebb0d..56b3574 100644 > --- a/drivers/usb/gadget/udc/mv_udc_core.c > +++ b/drivers/usb/gadget/udc/mv_udc_core.c > @@ -489,6 +489,7 @@ static int mv_ep_enable(struct usb_ep *_ep, > break; > case USB_ENDPOINT_XFER_CONTROL: > ios = 1; > + break;
are you SURE this is supposed to have this break statement? What if we want to initialize mult to 0 *also* for control endpoints? How did you test this? Do you have access to Marvel's documentation for this controller?
-- balbi [unhandled content-type:application/pgp-signature]
| |