Messages in this thread | | | Date | Tue, 7 Feb 2017 09:35:57 +0100 | From | Benjamin Tissoires <> | Subject | Re: [PATCH v2 05/15] HID: logitech-hidpp: forward device info in power_supply |
| |
Hi Bastien,
On Feb 03 2017 or thereabouts, Bastien Nocera wrote: > On Thu, 2017-02-02 at 15:12 +0100, Benjamin Tissoires wrote: > > + case POWER_SUPPLY_PROP_MANUFACTURER: > > + val->strval = "Logitech, Inc."; > > I don't like this change. I'd prefer the concatenated manufacturer and > model strings leading to user-friendly strings, and "Logitech T650" is > better than "Logitech, Inc. T650".
Is this the only problematic issue? We are at rc7 already so I would like to have the final version ready ASAP.
Cheers, Benjamin
| |