Messages in this thread | | | Subject | Re: [PATCH 13/18] HID-debug: Combine 11 seq_printf() calls into one call in hid_dump_field() | From | Joe Perches <> | Date | Tue, 07 Feb 2017 14:52:58 -0800 |
| |
On Tue, 2017-02-07 at 20:56 +0100, SF Markus Elfring wrote: > diff --git a/drivers/hid/hid-debug.c b/drivers/hid/hid-debug.c [] > @@ -614,19 +614,18 @@ void hid_dump_field(struct hid_field *field, int n, struct seq_file *f) { > tab(n, f); seq_printf(f, "Report Size(%u)\n", field->report_size); > tab(n, f); seq_printf(f, "Report Count(%u)\n", field->report_count); > tab(n, f); seq_printf(f, "Report Offset(%u)\n", field->report_offset); > - > - tab(n, f); seq_printf(f, "Flags( "); > + tab(n, f);
Consider converting tab(n, f) to seq_indent(f, n) making seq_indent a global function or maybe using a new name like seq_spaces, and converting the existing uses in net/ipv4/fib_trie.c appropriately.
| |