Messages in this thread | | | From | Raghava Aditya Renukunta <> | Subject | RE: [PATCH][V2] scsi: aacraid: rcode is unsigned and should be signed int | Date | Tue, 7 Feb 2017 19:35:54 +0000 |
| |
> -----Original Message----- > From: Colin King [mailto:colin.king@canonical.com] > Sent: Tuesday, February 7, 2017 3:51 AM > To: dl-esc-Aacraid Linux Driver <aacraid@microsemi.com>; James E . J . > Bottomley <jejb@linux.vnet.ibm.com>; Martin K . Petersen > <martin.petersen@oracle.com>; linux-scsi@vger.kernel.org > Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: [PATCH][V2] scsi: aacraid: rcode is unsigned and should be signed int > > EXTERNAL EMAIL > > > From: Colin Ian King <colin.king@canonical.com> > > aac_fib_send can return -ve error returns and hence rcode should > be signed. Currently the rcode >= 0 check is always true and -ve > errors are not being checked. > > Thanks to Dan Carpenter for spotting my original broken fix to this > issue. > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > ---
Reviewed-by: Raghava Aditya Renukunta <RaghavaAditya.Renukunta@microsemi.com>
| |