lkml.org 
[lkml]   [2017]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 00/10][v2] staging: fsl-mc: fixes and cleanups
Date


> -----Original Message-----
> From: laurentiu.tudor@nxp.com [mailto:laurentiu.tudor@nxp.com]
> Sent: Tuesday, February 07, 2017 8:15 AM
> To: gregkh@linuxfoundation.org
> Cc: devel@driverdev.osuosl.org; linux-kernel@vger.kernel.org; agraf@suse.de; arnd@arndb.de; Ioana
> Ciornei <ioana.ciornei@nxp.com>; Ruxandra Ioana Radulescu <ruxandra.radulescu@nxp.com>; Bharat Bhushan
> <bharat.bhushan@nxp.com>; Stuart Yoder <stuart.yoder@nxp.com>; Catalin Horghidan
> <catalin.horghidan@nxp.com>; Leo Li <leoyang.li@nxp.com>; Roy Pledge <roy.pledge@nxp.com>; linux-arm-
> kernel@lists.infradead.org; Laurentiu Tudor <laurentiu.tudor@nxp.com>
> Subject: [PATCH 00/10][v2] staging: fsl-mc: fixes and cleanups
>
> From: Laurentiu Tudor <laurentiu.tudor@nxp.com>
>
> First 4 patches fix several driver model related
> issues and drop an useless atomic global.
> The rest of the patches are cleanups mostly
> consisting in removing dead code.
>
> v2:
> - split slab cache removal in distinct patch
> - redundant deallocation dropped in patch that adds release callback

Laurentiu,

A few nits about this submission:

-every patch in the series should have had "v2" in the patch
subject. In your submission only the cover letter had it.
Without that it's harder to keep track of which version of
patch I'm looking at. Just use this when formatting your
patches:
--patch-subject="PATCH v2"

-for each patch, you should note below the "---" what changed in the
patch, and if there were no changes you put "no changes". For
an example see:
https://patchwork.kernel.org/patch/9478093/

(You can use "git notes" to manage the below the "---" comments
if it helps)

Can you reformat this series with "v3" and add the the comments
to note what did not change and what did change?

Thanks,
Stuart

\
 
 \ /
  Last update: 2017-02-07 15:55    [W:0.122 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site