lkml.org 
[lkml]   [2017]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] namei: Remove unlikely annotation for revalidate check in lookup_fast()
On Tue, 7 Feb 2017 00:06:42 +0000
Al Viro <viro@ZenIV.linux.org.uk> wrote:

> On Mon, Feb 06, 2017 at 05:17:35PM -0500, Steven Rostedt wrote:
> > From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>
> >
> > The likely/unlikely profiler showed that the unlikely around the
> > dentry->d_flags & DCACHE_OP_REVALIDATE was wrong 95% of the time. Adding
> > trace_printk()s, it revealed that the dentry ops had hooks to:
> >
> > kernfs_dop_revalidate
> > pid_revalidate
> > proc_sys_revalidate
> > tid_fd_revalidate
> >
> > As tools today now access files that have these operations often, it's best
> > just to remove the annotation, as it is more dependent on use cases and not
> > normal mode of operation if it will be true or not.
>
> "Tools" being what, exactly? What kind of load had that been measured on?

I first saw it on my system that I ran for 3 weeks. But I investigated
it more on a test box that was mostly idle. On the test box the "tools"
was mostly systemd and journald. I can look deeper into it if you like.

-- Steve


\
 
 \ /
  Last update: 2017-02-07 02:35    [W:0.593 / U:1.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site