lkml.org 
[lkml]   [2017]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH V2 2/2] ARM: dts: rockchip: add dts for RK3288-Tinker board
Hi Andrew

2017-02-06 10:54 GMT+08:00 Andrew Lunn <andrew@lunn.ch>:
> Hi Eddie
>
>> + button@0 {
>> + gpios = <&gpio0 5 GPIO_ACTIVE_LOW>;
>> + linux,code = <116>;
>
> It is a good idea to use include/dt-bindings/input/input.h
>
> and then you can replace <116> with < KEY_POWER > which is more
> readable.
Thanks, I will modify it in next version.
>
>> + label = "GPIO Key Power";
>> + linux,input-type = <1>;
>
> < EV_KEY >
>
>> + gpio-key,wakeup = <1>;
>
> This has been replace with wakeup-source.
Thanks, I will modify it in next version
>
>> + debounce-interval = <100>;
>> + };
>> + };
>
> Andrew

\
 
 \ /
  Last update: 2017-02-06 06:52    [W:0.133 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site