Messages in this thread | | | Date | Mon, 6 Feb 2017 13:41:16 +0100 | From | Borislav Petkov <> | Subject | Re: [RFC PATCH] perf/stat: Add --disable-hwdt |
| |
On Mon, Feb 06, 2017 at 01:22:31PM +0100, Ingo Molnar wrote: > Looks sensible, and I'd in fact make this the new default behavior (if root runs > perf stat) - i.e. add a flag to re-enable it, for the rare case where we want to > debug a hard deadlock while running perf stat ...
I'd probably only need to save the previous state, in case it was disabled for whatever reason.
So actually, I'll make it so that we restore the previous state at exit. Whatever it was. But while perf stat runs as root, we will disable it by default.
/me scratches head a bit...
Oh ok, even better - no need for a cmdline option then.
Or does it *ever* make sense to have watchdog running *while* perf stat runs too?
Because if it doesn't, turning it off by default *if* it was enabled
[ should be, we do enable HW WDT by default ]
and restoring it should be the proper thing to do. Without cmdline option.
Thanks!
-- Regards/Gruss, Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
| |