lkml.org 
[lkml]   [2017]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 16/24] media: Add i.MX media core driver
From
Date


On 02/02/2017 02:50 PM, Russell King - ARM Linux wrote:
> On Fri, Jan 06, 2017 at 06:11:34PM -0800, Steve Longerbeam wrote:
>> +/* register an internal subdev as a platform device */
>> +static struct imx_media_subdev *
>> +add_internal_subdev(struct imx_media_dev *imxmd,
>> + const struct internal_subdev *isd,
>> + int ipu_id)
>> +{
>> + struct imx_media_internal_sd_platformdata pdata;
>> + struct platform_device_info pdevinfo = {0};
>> + struct imx_media_subdev *imxsd;
>> + struct platform_device *pdev;
>> +
>> + switch (isd->id->grp_id) {
>> + case IMX_MEDIA_GRP_ID_CAMIF0...IMX_MEDIA_GRP_ID_CAMIF1:
>> + pdata.grp_id = isd->id->grp_id +
>> + ((2 * ipu_id) << IMX_MEDIA_GRP_ID_CAMIF_BIT);
>> + break;
>> + default:
>> + pdata.grp_id = isd->id->grp_id;
>> + break;
>> + }
>> +
>> + /* the id of IPU this subdev will control */
>> + pdata.ipu_id = ipu_id;
>> +
>> + /* create subdev name */
>> + imx_media_grp_id_to_sd_name(pdata.sd_name, sizeof(pdata.sd_name),
>> + pdata.grp_id, ipu_id);
>> +
>> + pdevinfo.name = isd->id->name;
>> + pdevinfo.id = ipu_id * num_isd + isd->id->index;
>> + pdevinfo.parent = imxmd->dev;
>> + pdevinfo.data = &pdata;
>> + pdevinfo.size_data = sizeof(pdata);
>> + pdevinfo.dma_mask = DMA_BIT_MASK(32);
>> +
>> + pdev = platform_device_register_full(&pdevinfo);
>> + if (IS_ERR(pdev))
>> + return ERR_CAST(pdev);
>> +
>> + imxsd = imx_media_add_async_subdev(imxmd, NULL, dev_name(&pdev->dev));
>> + if (IS_ERR(imxsd))
>> + return imxsd;
>> +
>> + imxsd->num_sink_pads = isd->num_sink_pads;
>> + imxsd->num_src_pads = isd->num_src_pads;
>> +
>> + return imxsd;
>> +}
> You seem to create platform devices here, but I see nowhere that you
> ever remove them - so if you get to the lucky point of being able to
> rmmod imx-media and then try to re-insert it, you end up with a load
> of kernel warnings, one for each device created this way, and
> platform_device_register_full() fails:

Right, I never free the platform devices for the internal subdevs.
Fixed.

Steve

\
 
 \ /
  Last update: 2017-02-07 02:55    [W:0.195 / U:4.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site