lkml.org 
[lkml]   [2017]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.10 256/319] packet: call fanout_release, while UNREGISTERING a netdev
    Date
    From: Anoob Soman <anoob.soman@citrix.com>

    commit 6664498280cf17a59c3e7cf1a931444c02633ed1 upstream.

    If a socket has FANOUT sockopt set, a new proto_hook is registered
    as part of fanout_add(). When processing a NETDEV_UNREGISTER event in
    af_packet, __fanout_unlink is called for all sockets, but prot_hook which was
    registered as part of fanout_add is not removed. Call fanout_release, on a
    NETDEV_UNREGISTER, which removes prot_hook and removes fanout from the
    fanout_list.

    This fixes BUG_ON(!list_empty(&dev->ptype_specific)) in netdev_run_todo()

    Signed-off-by: Anoob Soman <anoob.soman@citrix.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Willy Tarreau <w@1wt.eu>
    ---
    net/packet/af_packet.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c
    index 2d454a2..24f0066 100644
    --- a/net/packet/af_packet.c
    +++ b/net/packet/af_packet.c
    @@ -3384,6 +3384,7 @@ static int packet_notifier(struct notifier_block *this, unsigned long msg, void
    }
    if (msg == NETDEV_UNREGISTER) {
    packet_cached_dev_reset(po);
    + fanout_release(sk);
    po->ifindex = -1;
    if (po->prot_hook.dev)
    dev_put(po->prot_hook.dev);
    --
    2.8.0.rc2.1.gbe9624a
    \
     
     \ /
      Last update: 2017-02-05 20:49    [W:3.070 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site