lkml.org 
[lkml]   [2017]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.10 182/319] qxl: check for kmap failures
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    commit f4cceb2affcd1285d4ce498089e8a79f4cd2fa66 upstream.

    If kmap fails, it leads to memory corruption.

    Fixes: f64122c1f6ad ('drm: add new QXL driver. (v1.4)')
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
    Link: http://patchwork.freedesktop.org/patch/msgid/20160711084633.GA31411@mwanda
    Signed-off-by: Willy Tarreau <w@1wt.eu>
    ---
    drivers/gpu/drm/qxl/qxl_draw.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/gpu/drm/qxl/qxl_draw.c b/drivers/gpu/drm/qxl/qxl_draw.c
    index 3c8c3db..ff32052 100644
    --- a/drivers/gpu/drm/qxl/qxl_draw.c
    +++ b/drivers/gpu/drm/qxl/qxl_draw.c
    @@ -114,6 +114,8 @@ static int qxl_palette_create_1bit(struct qxl_bo **palette_bo,
    palette_bo);

    ret = qxl_bo_kmap(*palette_bo, (void **)&pal);
    + if (ret)
    + return ret;
    pal->num_ents = 2;
    pal->unique = unique++;
    if (visual == FB_VISUAL_TRUECOLOR || visual == FB_VISUAL_DIRECTCOLOR) {
    --
    2.8.0.rc2.1.gbe9624a
    \
     
     \ /
      Last update: 2017-02-05 20:40    [W:4.039 / U:1.212 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site