lkml.org 
[lkml]   [2017]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH net-next 2/6] net: dsa: simplify netdevice events handling
From
Date


On 02/03/2017 10:20 AM, Vivien Didelot wrote:
> Simplify the code handling the slave netdevice notifier call by
> providing a dsa_slave_changeupper helper for NETDEV_CHANGEUPPER, and so
> on (only this event is supported at the moment.)
>
> Return NOTIFY_DONE when we did not care about an event, and NOTIFY_OK
> when we were concerned but no error occurred, as the API suggests.
>
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
> ---

> static int dsa_slave_netdevice_event(struct notifier_block *nb,
> @@ -1529,8 +1514,11 @@ static int dsa_slave_netdevice_event(struct notifier_block *nb,
> {
> struct net_device *dev = netdev_notifier_info_to_dev(ptr);
>
> - if (dsa_slave_dev_check(dev))
> - return dsa_slave_port_event(dev, event, ptr);
> + if (dev->netdev_ops != &dsa_slave_netdev_ops)
> + return NOTIFY_DONE;

Why not keep the dsa_slave_dev_check() here?


--
Florian

\
 
 \ /
  Last update: 2017-02-04 03:44    [W:0.167 / U:0.692 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site