Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Tue, 28 Feb 2017 15:43:29 +0100 | Subject | Re: [PATCH 3/3] lib: add module support to linked list sorting tests |
| |
Hi Arnd,
On Tue, Feb 28, 2017 at 3:28 PM, Arnd Bergmann <arnd@arndb.de> wrote: > On Tue, Feb 28, 2017 at 2:06 PM, Geert Uytterhoeven > <geert@linux-m68k.org> wrote: > >> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug >> index 90b2348777495b72..32363ae022e3282a 100644 >> --- a/lib/Kconfig.debug >> +++ b/lib/Kconfig.debug >> @@ -1731,11 +1731,12 @@ config LKDTM >> Documentation/fault-injection/provoke-crashes.txt >> >> config TEST_LIST_SORT >> - bool "Linked list sorting test" >> - depends on DEBUG_KERNEL >> + tristate "Linked list sorting test" >> + depends on DEBUG_KERNEL || m > > I don't see any other test code with a "DEBUG_KERNEL || m" dependency, > but several that are "DEBUG_KERNEL && m". Maybe we should just > force it to be a module like the others? If there are good reasons to > have it built-in, I'd just drop the "|| m" here.
Some people want to run all tests at boot time, so forcing the test to be modular breaks that.
I used "|| m" as I like to enable all tests as modules, even when not using DEBUG_KERNEL.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |