Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Tue, 28 Feb 2017 12:43:14 +0100 | Subject | Re: [PATCH akpm v2] lib: test_sort: make it explicitly non-modular |
| |
Hi Paul,
On Tue, Jan 24, 2017 at 11:56 PM, Paul Gortmaker <paul.gortmaker@windriver.com> wrote: > The Kconfig currently controlling compilation of this code is: > > lib/Kconfig.debug:config TEST_SORT > lib/Kconfig.debug: bool "Array-based sort test" > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the couple traces of modular infrastructure use, so that > when reading the code there is no doubt it is builtin-only. > > Since module_init translates to device_initcall in the non-modular > case, the init ordering becomes slightly earlier when we change it > to use subsys_initcall as done here. However, since it is a self > contained test, this shouldn't be an issue and subsys_initcall > seems like a better fit for this particular case. > > We also delete the MODULE_LICENSE tag since that information is now > contained at the top of the file in the comments.
Yeah, MODULE_LICENSE is too easy to grep for... :-(
> Cc: Kostenzer Felix <fkostenzer@live.at> > Cc: Arnd Bergmann <arnd@arndb.de> > Cc: Andrew Morton <akpm@linux-foundation.org> > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Can we please stop doing this?
It's very valuable to have modular tests, so you can run them just by insmodding the test, instead of needing a separate kernel that runs them at boot.
Will send a revert + modular enablement...
Thanks!
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |