Messages in this thread | | | Date | Mon, 27 Feb 2017 17:49:49 -0600 | From | Rob Herring <> | Subject | Re: [PATCHv3 2/2] rtc: cpcap: new rtc driver |
| |
On Thu, Feb 23, 2017 at 02:03:53AM +0100, Sebastian Reichel wrote: > This driver supports the Motorola CPCAP PMIC found on > some of Motorola's mobile phones, such as the Droid 4. > > Tested-by: Tony Lindgren <tony@atomide.com> > Signed-off-by: Sebastian Reichel <sre@kernel.org> > --- > > Changes since PATCHv2: > - checkpatch fixes > - add comment for update irq > - introduced vendor prefix patch > Changes since PATCHv1: > - added device_init_wakeup() at the end of probe > - added Tested-by from Tony > > --- > .../devicetree/bindings/rtc/cpcap-rtc.txt | 13 + > drivers/rtc/Kconfig | 7 + > drivers/rtc/Makefile | 1 + > drivers/rtc/rtc-cpcap.c | 332 +++++++++++++++++++++ > 4 files changed, 353 insertions(+) > create mode 100644 Documentation/devicetree/bindings/rtc/cpcap-rtc.txt > create mode 100644 drivers/rtc/rtc-cpcap.c > > diff --git a/Documentation/devicetree/bindings/rtc/cpcap-rtc.txt b/Documentation/devicetree/bindings/rtc/cpcap-rtc.txt > new file mode 100644 > index 000000000000..2709c32baf2c > --- /dev/null > +++ b/Documentation/devicetree/bindings/rtc/cpcap-rtc.txt > @@ -0,0 +1,13 @@ > +Motorola CPCAP PMIC RTC > +------------------------------------
Need to state what this is a child of.
> + > +Requires node properties: > +- compatible: should contain "motorola,cpcap-rtc" > +- interrupts: An interrupt specifier for alarm and 1 Hz irq > + > +Example: > + > +cpcap_rtc: rtc { > + compatible = "motorola,cpcap-rtc"; > + interrupts = <39 IRQ_TYPE_NONE>, <26 IRQ_TYPE_NONE>; > +};
| |