lkml.org 
[lkml]   [2017]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] ASoC: spear: Remove redundant message
From
Date
On Feb 25 2017 19:33, dspmihai wrote:
> This was reported by checkpatch.pl
>
> Signed-off-by: Despotovici Mihai <despotovici.mihai@gmail.com>
> ---
> sound/soc/spear/spdif_in.c | 4 +---
> sound/soc/spear/spdif_out.c | 4 +---
> 2 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/sound/soc/spear/spdif_in.c b/sound/soc/spear/spdif_in.c
> index 977a078..0f3b1a8 100644
> --- a/sound/soc/spear/spdif_in.c
> +++ b/sound/soc/spear/spdif_in.c
> @@ -216,10 +216,8 @@ static int spdif_in_probe(struct platform_device *pdev)
> return -EINVAL;
>
> host = devm_kzalloc(&pdev->dev, sizeof(*host), GFP_KERNEL);
> - if (!host) {
> - dev_warn(&pdev->dev, "kzalloc fail\n");
> + if (!host)

The line for dev_warn() should be kept.

> return -ENOMEM;
> - }
>
> host->io_base = io_base;
> host->irq = platform_get_irq(pdev, 0);
> diff --git a/sound/soc/spear/spdif_out.c b/sound/soc/spear/spdif_out.c
> index 0a72d52..58d5843 100644
> --- a/sound/soc/spear/spdif_out.c
> +++ b/sound/soc/spear/spdif_out.c
> @@ -282,10 +282,8 @@ static int spdif_out_probe(struct platform_device *pdev)
> int ret;
>
> host = devm_kzalloc(&pdev->dev, sizeof(*host), GFP_KERNEL);
> - if (!host) {
> - dev_warn(&pdev->dev, "kzalloc fail\n");
> + if (!host)

Ditto.

> return -ENOMEM;
> - }
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> host->io_base = devm_ioremap_resource(&pdev->dev, res);

Takashi Sakamoto

\
 
 \ /
  Last update: 2017-02-26 09:05    [W:0.073 / U:3.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site