Messages in this thread | | | Subject | Re: [PATCH 4/7] watchdog: s3c2410: Add prefix to local function | From | Guenter Roeck <> | Date | Fri, 24 Feb 2017 13:58:54 -0800 |
| |
On 02/24/2017 01:07 PM, Krzysztof Kozlowski wrote: > Functions marked static inline might not be inlined so a driver-specific > prefix for function name helps when looking through call backtrace. > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> --- > drivers/watchdog/s3c2410_wdt.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/watchdog/s3c2410_wdt.c b/drivers/watchdog/s3c2410_wdt.c > index f7aad19d20ff..a031842ffcb0 100644 > --- a/drivers/watchdog/s3c2410_wdt.c > +++ b/drivers/watchdog/s3c2410_wdt.c > @@ -507,9 +507,8 @@ static inline unsigned int s3c2410wdt_get_bootstatus(struct s3c2410_wdt *wdt) > return 0; > } > > -/* s3c2410_get_wdt_driver_data */ > static inline struct s3c2410_wdt_variant * > -get_wdt_drv_data(struct platform_device *pdev) > +s3c2410_get_wdt_drv_data(struct platform_device *pdev) > { > if (pdev->dev.of_node) { > const struct of_device_id *match; > @@ -541,7 +540,7 @@ static int s3c2410wdt_probe(struct platform_device *pdev) > spin_lock_init(&wdt->lock); > wdt->wdt_device = s3c2410_wdd; > > - wdt->drv_data = get_wdt_drv_data(pdev); > + wdt->drv_data = s3c2410_get_wdt_drv_data(pdev); > if (wdt->drv_data->quirks & QUIRKS_HAVE_PMUREG) { > wdt->pmureg = syscon_regmap_lookup_by_phandle(dev->of_node, > "samsung,syscon-phandle"); >
| |