lkml.org 
[lkml]   [2017]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCH 07/10] orangefs: Use RCU for destroy_inode
That, AFAICS, fixes a real bug.  Applied, and it needs Cc:stable as well.


> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> ---
> fs/orangefs/super.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> --- a/fs/orangefs/super.c
> +++ b/fs/orangefs/super.c
> @@ -115,6 +115,13 @@ static struct inode *orangefs_alloc_inod
> return &orangefs_inode->vfs_inode;
> }
>
> +static void orangefs_i_callback(struct rcu_head *head)
> +{
> + struct inode *inode = container_of(head, struct inode, i_rcu);
> + struct orangefs_inode_s *orangefs_inode = ORANGEFS_I(inode);
> + kmem_cache_free(orangefs_inode_cache, orangefs_inode);
> +}
> +
> static void orangefs_destroy_inode(struct inode *inode)
> {
> struct orangefs_inode_s *orangefs_inode = ORANGEFS_I(inode);
> @@ -123,7 +130,7 @@ static void orangefs_destroy_inode(struc
> "%s: deallocated %p destroying inode %pU\n",
> __func__, orangefs_inode, get_khandle_from_ino(inode));
>
> - kmem_cache_free(orangefs_inode_cache, orangefs_inode);
> + call_rcu(&inode->i_rcu, orangefs_i_callback);
> }
>
> /*
>
>

\
 
 \ /
  Last update: 2017-02-24 21:52    [W:0.121 / U:0.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site