Messages in this thread | | | Subject | Re: [PATCH V4 6/6] proc: show MADV_FREE pages info in smaps | From | Dave Hansen <> | Date | Fri, 24 Feb 2017 09:08:30 -0800 |
| |
On 02/22/2017 10:50 AM, Shaohua Li wrote: > @@ -770,6 +774,7 @@ static int show_smap(struct seq_file *m, void *v, int is_pid) > "Private_Dirty: %8lu kB\n" > "Referenced: %8lu kB\n" > "Anonymous: %8lu kB\n" > + "LazyFree: %8lu kB\n" > "AnonHugePages: %8lu kB\n" > "ShmemPmdMapped: %8lu kB\n" > "Shared_Hugetlb: %8lu kB\n"
I've been as guily of this in the past as anyone, but are we just going to keep adding fields to smaps forever? For the vast, vast, majority of folks, this will simply waste the 21 bytes * nr_vmas that it costs us to print "LazyFree: 0 kB\n" over and over.
Should we maybe start a habit of not printing an entry when it's "0 kB"?
| |