Messages in this thread | | | From | Bart Van Assche <> | Subject | Re: [PATCH] ib_srp: Let compiler ignore the useless debug code | Date | Fri, 24 Feb 2017 16:16:31 +0000 |
| |
On Fri, 2017-02-24 at 16:44 +0800, Minfei Huang wrote: > "if (0)" is used to make this block of debug code not be executed. There > is a more elegant way to let compiler ignore this code, using > "#if 0 .. #endif" instead. > > Although it may be optimised by some compilers with specified parameter, > just for readable.
#if 0 / #endif prevents the compiler from checking the syntax of the code. Such code tends to grow syntax errors. So I'm not sure this patch is an improvement.
Bart.
| |