lkml.org 
[lkml]   [2017]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] checkpatch: don't complain on module_param(foo, bar, 0)
On Thu, Feb 9, 2017 at 2:05 AM, Brian Norris <briannorris@chromium.org> wrote:
> The following code snippet:
>
> module_param(writeable, bool, 0);
>
> yields this warning:
>
> ERROR: Use 4 digit octal (0777) not decimal permissions
> #390: FILE: drivers/mtd/spi-nor/intel-spi.c:143:
> +module_param(writeable, bool, 0);
> total: 1 errors, 0 warnings, 1006 lines checked
>
> But 0000 is no easier to read than 0, and module_param() even
> specifically refers to 0.

While this is all correct, the question is why we disallow to read
back on those parameters?

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2017-02-23 23:11    [W:0.383 / U:0.972 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site