Messages in this thread | | | Date | Fri, 24 Feb 2017 00:46:08 +0530 | From | "Naveen N. Rao" <> | Subject | Re: [PATCH v2 4/5] perf: kretprobes: offset from reloc_sym if kernel supports it |
| |
On 2017/02/23 06:10PM, Masami Hiramatsu wrote: > On Wed, 22 Feb 2017 19:23:40 +0530 > "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> wrote: > > > We indicate support for accepting sym+offset with kretprobes through a > > line in ftrace README. Parse the same to identify support and choose the > > appropriate format for kprobe_events. > > > > Signed-off-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com> > > --- > > tools/perf/util/probe-event.c | 47 ++++++++++++++++++++++++++++++++++++------- > > tools/perf/util/probe-event.h | 2 ++ > > 2 files changed, 42 insertions(+), 7 deletions(-) > >
[snip]
> > Could you reuse (refactoring) probe_type_is_available() in probe-file.c to share > opening README file?
Done. I've sent patches to do that, please review.
> > Others looks good to me :)
Thanks. I hope that's an Ack for this patchset?
If so, and if Ingo/Michael agree, would it be ok to take the kernel bits through the powerpc tree like we did for kprobe_exceptions_notify() cleanup?
Regards, Naveen
| |