lkml.org 
[lkml]   [2017]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 11/18] perf stat: Add -a as default target
On Mon, Feb 20, 2017 at 04:08:32PM -0300, Arnaldo Carvalho de Melo wrote:
> From: Jiri Olsa <jolsa@redhat.com>
>
> Boris asked for default -a option in case we monitor only uncore events.
>
> While implementing that I thought it might be actually useful to make it
> overall default.
>
> Running 'perf stat' will now collect system wide data.
>
> Committer note:
>
> Testing it:
>
> # perf stat
> ^C
> Performance counter stats for 'system wide':
>
> 3571.559178 cpu-clock (msec) # 4.000 CPUs utilized
> 3,346 context-switches # 0.937 K/sec
> 277 cpu-migrations # 0.078 K/sec
> 57,271 page-faults # 0.016 M/sec
> 4,535,633,835 cycles # 1.270 GHz
> 6,389,736,516 instructions # 1.41 insn per cycle
> 1,541,293,875 branches # 431.547 M/sec
> 14,526,396 branch-misses # 0.94% of all branches
>
> 0.892950118 seconds time elapsed
>
> #
>
> Requested-and-Acked-by: Borislav Petkov <bp@alien8.de>
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> Cc: David Ahern <dsahern@gmail.com>
> Cc: Jiri Olsa <jolsa@kernel.org>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Link: http://lkml.kernel.org/r/20170217170034.GB15389@krava
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> ---
> tools/perf/Documentation/perf-stat.txt | 2 +-
> tools/perf/builtin-stat.c | 3 ++-
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/Documentation/perf-stat.txt b/tools/perf/Documentation/perf-stat.txt
> index d96ccd4844df..aecf2a87e7d6 100644
> --- a/tools/perf/Documentation/perf-stat.txt
> +++ b/tools/perf/Documentation/perf-stat.txt
> @@ -63,7 +63,7 @@ report::
>
> -a::
> --all-cpus::
> - system-wide collection from all CPUs
> + system-wide collection from all CPUs (default if no target is specified)
>
> -c::
> --scale::
> diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
> index ca27a8a705ac..9989b03c21f2 100644
> --- a/tools/perf/builtin-stat.c
> +++ b/tools/perf/builtin-stat.c
> @@ -2445,8 +2445,9 @@ int cmd_stat(int argc, const char **argv, const char *prefix __maybe_unused)
> } else if (big_num_opt == 0) /* User passed --no-big-num */
> big_num = false;
>
> + /* Make system wide (-a) the default target. */
> if (!argc && target__none(&target))
> - usage_with_options(stat_usage, stat_options);
> + target.system_wide = true;
>
> if (run_count < 0) {
> pr_err("Run count must be a positive number\n");
> --

This one doesn't work, see https://lkml.kernel.org/r/20170218175225.5cylpqti7oluqehv@pd.tnic

I have a better diff there :-)

--
Regards/Gruss,
Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

\
 
 \ /
  Last update: 2017-02-20 20:16    [W:0.399 / U:0.872 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site