lkml.org 
[lkml]   [2017]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 12/18] perf record: Add -a as default target
    Date
    From: Jiri Olsa <jolsa@redhat.com>

    Running 'perf record' with no target (-a, -p, -t, etc) will now collect
    system wide data.

    Commiter notes:

    Testing it:

    [root@jouet ~]# perf record
    ^C[ perf record: Woken up 1 times to write data ]
    [ perf record: Captured and wrote 1.351 MB perf.data (366 samples) ]
    #

    is equivalent to:

    # perf record -a
    ^C[ perf record: Woken up 1 times to write data ]
    [ perf record: Captured and wrote 1.411 MB perf.data (978 samples) ]
    #

    Signed-off-by: Jiri Olsa <jolsa@kernel.org>
    Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    Cc: Borislav Petkov <bp@alien8.de>
    Cc: David Ahern <dsahern@gmail.com>
    Cc: Jiri Olsa <jolsa@kernel.org>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Link: http://lkml.kernel.org/r/20170217170018.GA15389@krava
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    ---
    tools/perf/Documentation/perf-record.txt | 2 +-
    tools/perf/builtin-record.c | 4 +++-
    2 files changed, 4 insertions(+), 2 deletions(-)

    diff --git a/tools/perf/Documentation/perf-record.txt b/tools/perf/Documentation/perf-record.txt
    index 27256bc68eda..b16003ec14a7 100644
    --- a/tools/perf/Documentation/perf-record.txt
    +++ b/tools/perf/Documentation/perf-record.txt
    @@ -157,7 +157,7 @@ OPTIONS

    -a::
    --all-cpus::
    - System-wide collection from all CPUs.
    + System-wide collection from all CPUs (default if no target is specified).

    -p::
    --pid=::
    diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
    index 6cd6776052e7..b87bbef73394 100644
    --- a/tools/perf/builtin-record.c
    +++ b/tools/perf/builtin-record.c
    @@ -1677,8 +1677,10 @@ int cmd_record(int argc, const char **argv, const char *prefix __maybe_unused)

    argc = parse_options(argc, argv, record_options, record_usage,
    PARSE_OPT_STOP_AT_NON_OPTION);
    +
    + /* Make system wide (-a) the default target. */
    if (!argc && target__none(&rec->opts.target))
    - usage_with_options(record_usage, record_options);
    + rec->opts.target.system_wide = true;

    if (nr_cgroups && !rec->opts.target.system_wide) {
    usage_with_options_msg(record_usage, record_options,
    --
    2.9.3
    \
     
     \ /
      Last update: 2017-02-20 20:11    [W:4.320 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site